[PATCH] D64931: Change X86 datalayout for three address spaces that specify pointer sizes.

[Matt Arsenault via Phabricator via cfe-commits]

arsenm added a comment.

In D64931#1633669 <https://reviews.llvm.org/D64931#1633669>, @akhuang wrote:

> > Address space have backend defined semantics, and aren’t really reserved for front end use. I think the fact that non-0 address spaces on X86 codegen the same as address space 0 and could be used for something by a front end is an accident of how SelectionDAG is implemented. If X86 wants to reserve address space ranges for frontend use, that would need to be decided and documented. You don’t necessarily get the current behavior for free in GlobalISel since pointer types are distinct, so this would specifically need to be implemented.
>
> By this do you mean that this would be an instance of address spaces being used by the frontend? Or just that adding meaning to address spaces shouldn't be breaking other frontends?


I mean if frontends are relying on current specific behavior for these address spaces, that’s not something that’s documented to work. It just happens to


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64931/new/

https://reviews.llvm.org/D64931