[PATCH] D66353: [clang-doc] Redesign of generated HTML files

[Julie Hockett via Phabricator via cfe-commits]

juliehockett added inline comments.


================
Comment at: clang-tools-extra/clang-doc/HTMLGenerator.cpp:487-489
+static std::unique_ptr<TagNode>
+genFileMainNode(StringRef InfoPath,
+                std::vector<std::unique_ptr<TagNode>> &MainContentInnerNodes,
----------------
Would you be able to briefly comment on each of these `gen*Node` functions on what exactly they're doing? I'm having trouble getting a picture of what the flow is there


================
Comment at: clang-tools-extra/clang-doc/HTMLGenerator.cpp:523
+  auto SpanNode =
+      std::make_unique<TagNode>(HTMLTag::TAG_SPAN, "clang-doc version unknown");
+  SpanNode->Attributes.emplace_back("class", "no-break");
----------------
Try using `getClangToolFullVersion` for here? https://clang.llvm.org/doxygen/namespaceclang.html#a35fdf9e05d2640414289e62cc837bf78


================
Comment at: clang-tools-extra/clang-doc/HTMLGenerator.cpp:828
+  std::vector<std::unique_ptr<TagNode>> MainContentNodes;
+  std::make_unique<TagNode>(HTMLTag::TAG_DIV);
   Index InfoIndex;
----------------
This isn't doing anything


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66353/new/

https://reviews.llvm.org/D66353