[PATCH] D64464: [CodeGen] Emit destructor calls for non-trivial C structs

Gabor Marton via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Aug 16 05:03:30 PDT 2019


martong added inline comments.


================
Comment at: test/Import/objc-arc/Inputs/cleanup-objects.m:6
+id getObj(int c, id a) {
+  // Commenting out the following line because AST importer crashes when trying
+  // to import a BlockExpr.
----------------
Perhaps then this patch depends on another patch which implements the import of a BlockExpr?
Or maybe the branch `if (auto *BD = From.dyn_cast<BlockDecl *>())` should be left out from the ASTImporter code, and this way BlockExpr and BlockDecl would be implemented later in another patch.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64464/new/

https://reviews.llvm.org/D64464





More information about the cfe-commits mailing list