[PATCH] D59692: [ASTImporter] Fix name conflict handling

Gabor Marton via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Aug 16 03:23:40 PDT 2019


martong marked an inline comment as done.
martong added a comment.

In D59692#1632138 <https://reviews.llvm.org/D59692#1632138>, @shafik wrote:

> Just wanted to see if you were planning on landing this soon, the fix `Name` -> `SearchName` is probably an important one since we have seen several issues w/ bugs like that but I really would like to see more tests. Are you having issues coming up w/ tests?


Hey Shafik, I was busy lately with some non-ASTImporter related tasks, but just recently I could drive myself back to it.
I am planning to add the test cases in the following work days, but the latest by the end of the next week.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59692/new/

https://reviews.llvm.org/D59692





More information about the cfe-commits mailing list