[PATCH] D66324: clang-misexpect: Profile Guided Validation of Performance Annotations in LLVM

Roman Lebedev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Aug 15 23:40:22 PDT 2019


lebedev.ri added reviewers: lebedev.ri, vsk.
lebedev.ri added a comment.

This is marked as child revision of D65300 <https://reviews.llvm.org/D65300> but it seems like they both add
the same logic, just into different components, D65300 <https://reviews.llvm.org/D65300> to clang, this to llvm.
Is this duplication or are the diffs concurrent?
Can D65300 <https://reviews.llvm.org/D65300> be re-implemented to just use this llvm code?

I'm also thinking the clang-misexpect *tool* should be a separate change,
it's misleading to have it here as it gives impression that it **has** to be used,
which i'm not sure is so?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66324/new/

https://reviews.llvm.org/D66324





More information about the cfe-commits mailing list