[PATCH] D66298: [clang-doc] Fix records in global namespace

Julie Hockett via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Aug 15 08:56:43 PDT 2019


juliehockett added inline comments.


================
Comment at: clang-tools-extra/unittests/clang-doc/SerializeTest.cpp:299
   RecordInfo *G = InfoAsRecord(Infos[2].get());
-  RecordInfo ExpectedG(EmptySID, /*Name=*/"G", /*Path=*/"E");
+  RecordInfo ExpectedG(EmptySID, /*Name=*/"G", /*Path=*/"GlobalNamespace/E");
   ExpectedG.DefLoc = Location(0, llvm::SmallString<16>{"test.cpp"});
----------------
Native path?


================
Comment at: clang-tools-extra/unittests/clang-doc/SerializeTest.cpp:434
   ExpectedParentB.ChildRecords.emplace_back(EmptySID, "B", InfoType::IT_record,
-                                            "A");
+                                            "GlobalNamespace/A");
   CheckRecordInfo(&ExpectedParentB, ParentB);
----------------
Native path?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66298/new/

https://reviews.llvm.org/D66298





More information about the cfe-commits mailing list