[PATCH] D66294: [Docs][OpenCL] Release 9.0 notes for OpenCL

[Sven van Haastregt via Phabricator via cfe-commits]

svenvh added inline comments.


================
Comment at: docs/ReleaseNotes.rst:173
+
+- Added initial support for implicitly including OpenCL BIFs using
+  efficient trie lookup generated by TableGen. A corresponding
----------------
mantognini wrote:
> If the BIF acronym wasn't introduced before, it should be replaced with "builtin functions". It seems we don't have more file context in this review so I cannot tell.
BIFs -> built-in functions


================
Comment at: docs/ReleaseNotes.rst:175
+  efficient trie lookup generated by TableGen. A corresponding
+  frontend only flag ``-fadd-opencl-builtins`` has been added to
+  enable trie during parsing.
----------------
mantognini wrote:
> I'm not 100% sure about the grammar rule in English, but shouldn't there be a "-" between "frontend" and "only" here to make it an adjective-ish?
The flag is called `-fdeclare-opencl-builtins` (not -fadd...).


================
Comment at: docs/ReleaseNotes.rst:176
+  frontend only flag ``-fadd-opencl-builtins`` has been added to
+  enable trie during parsing.
+
----------------
The option does not only "enable a trie" during parsing.  I'd suggest to just drop "to enable trie during parsing".


================
Comment at: docs/ReleaseNotes.rst:179
+- Refactored header file to be used for common parts between
+  regular header and TableGen trie.
+
----------------
Refactored the `opencl-c.h` header file ...

TableGen trie -> `-fdeclare-opencl-builtins`.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66294/new/

https://reviews.llvm.org/D66294