[PATCH] D65182: [analyzer] Add fix-it hint support.

Kristóf Umann via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Aug 14 16:15:26 PDT 2019


Szelethus accepted this revision.
Szelethus added a comment.

In D65182#1630540 <https://reviews.llvm.org/D65182#1630540>, @NoQ wrote:

> In D65182#1629192 <https://reviews.llvm.org/D65182#1629192>, @Szelethus wrote:
>
> > Hmm, why the need for checker options? Why not have them by default? If fixits are an experimental feature, maybe we should have a global `enable-fixits` config. But I don't insist :)
>
>
> I did this because fixits have a much higher quality standard that warnings (because people often apply them blindly). This means that fixit support is likely to be lagging behind in meeting the quality standards and therefore it's important to allow some (but not necessarily all) on-by-default checkers have alpha fixits.


I'm sold.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65182/new/

https://reviews.llvm.org/D65182





More information about the cfe-commits mailing list