[PATCH] D66247: [OpenMP] Fix target map for unused variables

Wed Aug 14 15:09:11 PDT 2019

ABataev added a comment.

In D66247#1630398 <https://reviews.llvm.org/D66247#1630398>, @jdenny wrote:

> In D66247#1630352 <https://reviews.llvm.org/D66247#1630352>, @ABataev wrote:
>
> > Yes, just realized that, defaultmap does not affect explicit firstprivates. Then just check `map(a) firstprivate(a)` for `int128` type. Check that it still has `tofrom` mapping. If so, then probably we already can handle such combinations correctly in the codegen. Also, test it for other mapping types, like alloc, from, to.
>
>
> All work as expected.

Then just add the tests for as many different combinations as possible to be sure that we did not miss anything.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66247/new/

https://reviews.llvm.org/D66247