[PATCH] D66254: Correct include suggestion when search path includes symlink

Ben Jackson via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Aug 14 13:57:34 PDT 2019


puremourning added a comment.

FYI this fixes the issue in https://github.com/clangd/clangd/issues/124

I haven't added new tests to HeaderSearchTest.cc because the InMemoryFileSystem doesn't support symlinks and I didn't want to try and implement that for this patch. Let me know thoughts on alternative ways to regression test it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66254/new/

https://reviews.llvm.org/D66254





More information about the cfe-commits mailing list