[PATCH] D66221: [clangd] Added highlighting for non type templates.

Ilya Biryukov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Aug 14 09:27:51 PDT 2019


ilya-biryukov added inline comments.


================
Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:231
+          if (TP->isFunctionPointerType()) {
+            addToken(Loc, HighlightingKind::Function);
+            return;
----------------
Why do we special-case template parameters, but not other kinds of variables?
We definitely need a comment explaining why template parameters are handled in a special way, but variables, parameters, fields are not.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66221/new/

https://reviews.llvm.org/D66221





More information about the cfe-commits mailing list