[PATCH] D65997: Add options rounding and exceptions to pragma fp

Serge Pavlov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Aug 14 08:40:40 PDT 2019


sepavloff marked 2 inline comments as done.
sepavloff added inline comments.


================
Comment at: clang/lib/Parse/ParsePragma.cpp:2697
     PP.Lex(Tok);
+    StringRef ExpectedArgumentText;
+    switch (*FlagKind) {
----------------
aaron.ballman wrote:
> sepavloff wrote:
> > aaron.ballman wrote:
> > > Same here.
> > This case is different from the above, the list of expected arguments depend on the current option.
> The case isn't different in the way that matters -- all of the strings that get passed in to the diagnostic come from string literals. You should be able to put the literals into the %select and map `TokFPAnnotValue::*` to an index, right?
I see, thank you)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65997/new/

https://reviews.llvm.org/D65997





More information about the cfe-commits mailing list