r368853 - [analyzer][NFC] Prove that we only track the evaluated part of the condition
Kristof Umann via cfe-commits
cfe-commits at lists.llvm.org
Wed Aug 14 06:51:52 PDT 2019
Author: szelethus
Date: Wed Aug 14 06:51:52 2019
New Revision: 368853
URL: http://llvm.org/viewvc/llvm-project?rev=368853&view=rev
Log:
[analyzer][NFC] Prove that we only track the evaluated part of the condition
...because we're working with a BugReporterVisitor, and the non-evaluated part
of the condition isn't in the bugpath.
Differential Revision: https://reviews.llvm.org/D65290
Modified:
cfe/trunk/test/Analysis/track-control-dependency-conditions.cpp
Modified: cfe/trunk/test/Analysis/track-control-dependency-conditions.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Analysis/track-control-dependency-conditions.cpp?rev=368853&r1=368852&r2=368853&view=diff
==============================================================================
--- cfe/trunk/test/Analysis/track-control-dependency-conditions.cpp (original)
+++ cfe/trunk/test/Analysis/track-control-dependency-conditions.cpp Wed Aug 14 06:51:52 2019
@@ -532,6 +532,7 @@ void f(int flag) {
}
#undef assert
+
} // end of namespace dont_track_assertlike_and_conditions
namespace dont_track_assertlike_or_conditions {
@@ -697,3 +698,37 @@ void f(int flag) {
#undef assert
} // end of namespace dont_track_assert2like_or_conditions
+
+namespace only_track_the_evaluated_condition {
+
+bool coin();
+
+void bar(int &flag) {
+ flag = coin(); // tracking-note{{Value assigned to 'flag'}}
+}
+
+void bar2(int &flag2) {
+ flag2 = coin();
+}
+
+void f(int *x) {
+ if (x) // expected-note{{Assuming 'x' is null}}
+ // debug-note at -1{{Tracking condition 'x'}}
+ // expected-note at -2{{Taking false branch}}
+ return;
+
+ int flag, flag2;
+ bar(flag); // tracking-note{{Calling 'bar'}}
+ // tracking-note at -1{{Returning from 'bar'}}
+ bar2(flag2);
+
+ if (flag && flag2) // expected-note {{Assuming 'flag' is 0}}
+ // expected-note at -1{{Left side of '&&' is false}}
+ // debug-note at -2{{Tracking condition 'flag'}}
+ return;
+
+ *x = 5; // expected-warning{{Dereference of null pointer}}
+ // expected-note at -1{{Dereference of null pointer}}
+}
+
+} // end of namespace only_track_the_evaluated_condition
More information about the cfe-commits
mailing list