[PATCH] D66215: [clangd] Print qualifiers of out-of-line definitions in document outline

[Ilya Biryukov via Phabricator via cfe-commits]

ilya-biryukov added inline comments.


================
Comment at: clang-tools-extra/clangd/AST.cpp:106
+
+/// Returns a nested name specifier if \p ND refers to a an out-of-line
+/// definition.
----------------
hokein wrote:
>  `if .. out-of-line definition` seems a bit confusing, I think here we just return a nested name specifier if it is written/present in the source code?
Good point, probably too many related concepts (and even synonyms) mentioned in one function.
Renamed to `getQualifier` and not mentioning the out-of-line definition anymore.

With the examples, it should be clear what this function is doing.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66215/new/

https://reviews.llvm.org/D66215