[PATCH] D66211: [clangd][vscode] Surface the error when applying tweaks fails

Haojian Wu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Aug 14 06:34:53 PDT 2019


hokein added inline comments.


================
Comment at: clang-tools-extra/clangd/clients/clangd-vscode/src/extension.ts:109
+        // Keep the default behavior.
+        if (error instanceof vscodelc.ResponseError &&
+            error.code === vscodelc.ErrorCodes.RequestCancelled)
----------------
ilya-biryukov wrote:
> Is this how default implementation behaves? Is there a way to call into it instead of re-implementing?
> If so, it would be nice to do so. If not, I'm also ok if we keep it.
manage to figure out a way to do it. We have to define a subclass of LanguageClient, and override logFailedRequest. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66211/new/

https://reviews.llvm.org/D66211





More information about the cfe-commits mailing list