[PATCH] D66152: Fix false negatives of statement local lifetime analysis for some STL implementation

Dmitri Gribenko via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Aug 14 02:42:02 PDT 2019


gribozavr accepted this revision.
gribozavr added inline comments.
This revision is now accepted and ready to land.


================
Comment at: clang/lib/Sema/SemaInit.cpp:6579
+      if (Name.size() >= 2 && Name.front() == '_' &&
+          (Name[1] == '_' || llvm::toUpper(Name[1]) == Name[1]))
+        return true;
----------------
Please use isUppercase from include/clang/Basic/CharInfo.h.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66152/new/

https://reviews.llvm.org/D66152





More information about the cfe-commits mailing list