[PATCH] D66068: cmake: Make building clang-shlib optional

Tue Aug 13 12:41:35 PDT 2019

beanz added a comment.

I want to dissect this a bit.

In D66068#1627451 <https://reviews.llvm.org/D66068#1627451>, @E5ten wrote:

> I am in favour of adding a user-facing option to disable generating this duplicate library for users that don't need it

Why do you call this duplicate? It is unique. There is no other library in the clang build that serves the role of this library.

> there should be an option to disable linking a library that takes a long time to link and isn't necessary for a lot of users.

I think this is nuanced. When you say "takes a long time to link", I'm curious why you say that. For me it takes 45s to link on my laptop in a Linux VM using LLD in a build configuration that also includes all our backends (which is kinda a worst-case scenario), and 10s to link if I only include X86. That doesn't seem like a super long time, and it doesn't rely on any billion-dollar compute farms.

While it does slow down full-build times (slightly), I think the benefit is less broken bots which benefits the community as a whole.

Going back to @jvesely's original email, I'm not sure why this adds minutes to your build time. I'd be curious if there are other low-hanging fruit that would improve your productivity without the community cost of adding new build configurations that disable building and testing things that we actually ship.

Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66068/new/

https://reviews.llvm.org/D66068