[PATCH] D65819: [Driver][Bundler] Improve bundling of object files.
Jonas Hahnfeld via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Aug 13 11:41:05 PDT 2019
Hahnfeld added inline comments.
================
Comment at: tools/clang-offload-bundler/ClangOffloadBundler.cpp:541-549
std::vector<StringRef> ClangArgs = {"clang",
- "-r",
+ "-c",
"-target",
TargetName.c_str(),
"-o",
OutputFileNames.front().c_str(),
- InputFileNames[HostInputIndex].c_str(),
----------------
Hahnfeld wrote:
> I think we should revert this change and just bundle the host object file as we do for all other targets.
To be clear: I agree that bundling + unbundling should result in the exact same object file, so the other changes seem good, just having the host object file easily accessible should be preserved.
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D65819/new/
https://reviews.llvm.org/D65819
More information about the cfe-commits
mailing list