[PATCH] D66068: cmake: Make building clang-shlib optional

Chris Bieneman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Aug 13 10:13:33 PDT 2019


beanz added a comment.

In D66068#1626266 <https://reviews.llvm.org/D66068#1626266>, @jvesely wrote:

> That's your workflow. I need to run 'make install' because the modifications are used by an external project. If there's an option to skip shlib during 'make install' I'd be happy to use it.


This is a really odd workflow, and not at all how our project is designed to be used. We have CMake exports explicitly to allow building against a build directory instead of needing to install.

> I'm pretty sure more people would appreciate not installing large duplicate libraries, but if a hidden option will do, I'll update the patch.

Running `make install` is massively contrary to this stated issue. Our `install` target generally installs pretty much everything, which is likely duplicating libraries. If you can't change your workflow to not rely on running `install`, I'd suggest you use the `LLVM_DISTRIBUTION_COMPONENTS` option (http://llvm.org/docs/BuildingADistribution.html), to hand tailor what pieces of LLVM you actually care about. That will give you the most optimal build cycle.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66068/new/

https://reviews.llvm.org/D66068





More information about the cfe-commits mailing list