[PATCH] D66045: Improve detection of same value in comparisons

[JF Bastien via Phabricator via cfe-commits]

jfb added inline comments.


================
Comment at: test/SemaCXX/self-comparison.cpp:87
+};
+} // namespace member_tests
----------------
rtrieu wrote:
> rtrieu wrote:
> > jfb wrote:
> > > The test only has `==`. Do other operators trigger?
> > All the standard comparison operators will work here.  I'll add tests.
> All operator tests added.
`operator<=>`?

Is there a separate test for user-defined operators as well? What makes sense in these cases? Technically a user-defined comparison could do anything... but I think this warning makes sense for them as well.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66045/new/

https://reviews.llvm.org/D66045