[PATCH] D66068: cmake: Make building clang-shlib optional

Chris Bieneman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Aug 12 15:01:16 PDT 2019


beanz added a comment.

I think you and I disagree here. General developer workflows don't need to include building `all` for every minor change. In my normal workflow I just re-run `check-llvm` or `check-clang` over and over again, only building the `all` target before I post a patch. With that workflow I only build the library once per-patch to ensure that it builds. Which is exactly the goal of not having it be included.

If you *really* *really* can't be bothered to ensure that the things we ship actually build with your change you can always use the (undocumented, and hidden) `CLANG_TOOL_CLANG_SHLIB_BUILD=Off` option. I really don't see a reason to add a user-facing option that we don't want people using.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66068/new/

https://reviews.llvm.org/D66068





More information about the cfe-commits mailing list