[PATCH] D66100: Add __has_builtin support for builtin function-like type traits.
    Aaron Ballman via Phabricator via cfe-commits 
    cfe-commits at lists.llvm.org
       
    Mon Aug 12 13:13:46 PDT 2019
    
    
  
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM aside from some nits.
================
Comment at: docs/LanguageExtensions.rst:65
+
+  ``__has_builtin`` should not be used to detect support for a built-in macro;
+  use ``#ifdef`` instead.
----------------
built-in -> builtin
(for consistency)
================
Comment at: docs/LanguageExtensions.rst:1120
+  Return ``true`` if ``type`` is a complete type.
+  Warning: this trait is dangerous, because it can return different values at
+  different points in the same program.
----------------
Drop the comma.
Repository:
  rC Clang
CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66100/new/
https://reviews.llvm.org/D66100
    
    
More information about the cfe-commits
mailing list