[PATCH] D66035: [WebAssembly] WIP: Add support for reference types

[Jacob Gravelle via Phabricator via cfe-commits]

jgravelle-google added a comment.

Overall direction looks good to me as well.

Ditto that tests would be useful just to make it clearer how this is represented in IR.



================
Comment at: llvm/lib/Target/WebAssembly/WebAssemblyISelLowering.h:47
+  MVT getPointerTy(const DataLayout &DL, uint32_t AS = 0) const override {
+    return AS == 1 ? MVT::anyref :
+      MVT::getIntegerVT(DL.getPointerSizeInBits(AS));
----------------
We'll almost-surely want to pull this `1` out into a constant, `WasmAnyrefAddressSpace` or something


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66035/new/

https://reviews.llvm.org/D66035