[PATCH] D66068: cmake: Make building clang-shlib optional

Chris Bieneman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Aug 12 10:30:57 PDT 2019


beanz added a comment.

I generally am not a fan of adding more and more options. As long as you're not linking the library it won't be generated by any of the check targets. With the llvm dylib we've had many issues over the years where changes to LLVM break building the dylib and many developers don't build it, so we have to wait for a bot to catch it. Making the clang dylib build as part of `all` in every possible build configuration is a recognition that this is something we ship and we should ensure works.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66068/new/

https://reviews.llvm.org/D66068





More information about the cfe-commits mailing list