[PATCH] D66074: [clangd] Drop diags from non-written #include.

[Ilya Biryukov via Phabricator via cfe-commits]

ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.

LGTM, thanks!
We should also merge this into the release branch if it's not too late yet.



================
Comment at: clang-tools-extra/clangd/unittests/DiagnosticsTests.cpp:952
+TEST(IgnoreDiags, FromNonWrittenInclude) {
+  TestTU TU = TestTU::withCode("");
+  TU.ExtraArgs.push_back("--include=a.h");
----------------
Could you add a comment describing which diagnostic we do **not** want to see here and why?
I assume it's `main should return int`, right?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66074/new/

https://reviews.llvm.org/D66074