[PATCH] D63423: [Diagnostics] Diagnose misused xor as pow

Sat Aug 10 09:27:33 PDT 2019

xbolva00 marked an inline comment as done.
xbolva00 added inline comments.

================
Comment at: include/clang/Basic/DiagnosticGroups.td:508
 def Varargs : DiagGroup<"varargs">;
+def XorUsedAsPow : DiagGroup<"xor-used-as-pow">;

----------------
aaron.ballman wrote:
> xbolva00 wrote:
> > jfb wrote:
> > > Does this match the naming that GCC ended up with?
> > No, they have no progress yet.  GCC should not block our progress here..
> Agreed, but we should still coordinate to ensure the names we pick are the same since this is a user-facing option. If GCC isn't adding this yet, can you file a bug report (or comment on an existing one) with the name we've chosen?
I will inform them after patch approval.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63423/new/

https://reviews.llvm.org/D63423