[PATCH] D65149: [Format] Add test demonstrating PR42722

MyDeveloperDay via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sat Aug 10 06:43:12 PDT 2019


MyDeveloperDay added inline comments.


================
Comment at: clang/unittests/Format/FormatTest.cpp:5184
+               "    c++;\n"
+               "    d++\n"
+               "  });\n"
----------------
modocache wrote:
> This is a passing test that demonstrates that the indentation of `c++` and `d++` here is wacky.
in what way do you think its incorrect? change the test to show what it should be...I think its better to commit a fix and a test at the same time then its easier for the reviewer and others to understand what you are driving at.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65149/new/

https://reviews.llvm.org/D65149





More information about the cfe-commits mailing list