[PATCH] D63423: [Diagnostics] Diagnose misused xor as pow

Dávid Bolvanský via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sat Aug 10 05:53:27 PDT 2019


xbolva00 added a comment.

Hello,

I fixed your notes + added test cases.

Only remaining question is what to do in "2 ^ 64" (65, 66, .. etc) case. I can emit "result of 2 ^ 64" is "XYZ", but this is rather poor diagnostic. What should we suggest for "2 ^ 64"? (@jfb

The "2 ^ 64 - 1" case to be solved as follow up patch..

And since there is no progress on GCC side, I will use -Wxor-used-as-pow


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63423/new/

https://reviews.llvm.org/D63423





More information about the cfe-commits mailing list