[PATCH] D65577: [ASTImporter] Import default expression of param before creating the param.
Gabor Marton via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Sat Aug 10 01:44:42 PDT 2019
martong added inline comments.
================
Comment at: clang/test/Analysis/Inputs/ctu-other.cpp:135
+
+struct DefParmContext {
+ static const int I;
----------------
balazske wrote:
> martong wrote:
> > shafik wrote:
> > > martong wrote:
> > > > Perhaps we could write `Default` instead of `Def`.
> > > +1 to this and the name suggestion below.
> > Please do not forget to rename.
> I did not get response to the name of `testDefParmIncompleteImport`, I think `testImportOfIncompleteDefaultParm` is not good, probably `testImportOfIncompleteDefaultParmDuringImport` is better.
Okay, so let's proceed with `testImportOfIncompleteDefaultParmDuringImport`.
Thanks!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D65577/new/
https://reviews.llvm.org/D65577
More information about the cfe-commits
mailing list