[PATCH] D65752: [Sema] Refactor LookupVisibleDecls. NFC
Sam McCall via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri Aug 9 16:24:18 PDT 2019
sammccall added a comment.
This looks reasonable to me, there are a couple of variations you might think about:
- also treat QualifiedNameLookup as an option, and override in places with an RAII pattern like `ScopedOverride Unqual(QualifiedNameLookup, false)` (why don't we have a class like that?). This would further reduce args.
- put the options in a `LookupOpts` struct and pass it by const reference - this is a less invasive change
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D65752/new/
https://reviews.llvm.org/D65752
More information about the cfe-commits
mailing list