[PATCH] D65835: [OpenMP] Fix map/is_device_ptr with DSA on combined directive

[Hal Finkel via Phabricator via cfe-commits]

hfinkel added a comment.

In D65835#1623772 <https://reviews.llvm.org/D65835#1623772>, @ABataev wrote:

> In D65835#1623756 <https://reviews.llvm.org/D65835#1623756>, @kkwli0 wrote:
>
> > In D65835#1622042 <https://reviews.llvm.org/D65835#1622042>, @ABataev wrote:
> >
> > > > I want to be sure we're on the same page: For OpenMP 5.0, should we allow is_device_ptr with the private clauses?
> > >
> > > Yes, since it is allowed by the standard.
> >
> >
> > Umm ... I probably missed some earlier discussions!  What would be the behavior of the following code?
> >
> >   p = omp_target_alloc(...);
> >   #pragma omp target private(p) is_device_ptr(p)
> >     p[...] = ...;   // crash or not?
> >
>
>
> It must crush, I assume. The main problem is that this construct is allowed by the standard.


Yep. We should add a warning message for it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65835/new/

https://reviews.llvm.org/D65835