[PATCH] D65180: [analyzer] VirtualCallChecker: Improve warning messages.

[Artem Dergachev via Phabricator via cfe-commits]

NoQ updated this revision to Diff 214441.
NoQ added a comment.

- Fix checker names for consumers that display them (eg., clang-tidy). Add a test.
- Change bug descriptions: "Call to virtual function during construction or destruction" -> "Pure virtual method call" | "Unexpected loss of virtual dispatch"
- Remove the suggestion to explicitly qualify the call. It is incorrect for nested stack frames, as it may affect the behavior when the same function is called from elsewhere.
- Make the category reusable, fix capitalization to stay similar to other bug categories.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65180/new/

https://reviews.llvm.org/D65180

Files:
  clang/include/clang/StaticAnalyzer/Core/BugReporter/CommonBugCategories.h
  clang/lib/StaticAnalyzer/Checkers/VirtualCallChecker.cpp
  clang/lib/StaticAnalyzer/Core/CommonBugCategories.cpp
  clang/test/Analysis/virtualcall-plist.cpp
  clang/test/Analysis/virtualcall.cpp
  clang/test/Analysis/virtualcall.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D65180.214441.patch
Type: text/x-patch
Size: 13303 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20190809/9929d07b/attachment-0001.bin>