[PATCH] D65997: Add options rounding and exceptions to pragma fp

[Kevin P. Neal via Phabricator via cfe-commits]

kpn added inline comments.


================
Comment at: clang/docs/LanguageExtensions.rst:3151
+value ``dynamic`` informs the compiler that it must not assume particular
+rounding mode. This option is experimental, compiler does not guarantee to
+process it in all cases.
----------------
aaron.ballman wrote:
> The last sentence is a bit ambiguous because "this option" could mean "rounding modes in general" or it could mean "the dynamic rounding mode". I would reword it to:
> 
> `compiler does not guarantee to process it in all cases -> the compiler may ignore a dynamic rounding mode in some situations`
> 
> or
> 
> `compiler does not guarantee to process it in all cases -> the compiler may ignore an explicit rounding mode in some situations`
> 
> 
> 
I'd go with the latter, or perhaps "the compiler may ignore the rounding mode setting in some situations." 

Currently, sometimes llvm will ignore the setting entirely, other times it will assume dynamic despite the setting being more specific. 

Also:
s/assume particular/assume any particular/
s/experimental, compiler/experimental; the compiler/


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65997/new/

https://reviews.llvm.org/D65997