[PATCH] D65212: [analyzer] Fix exporting SARIF files from scan-build on Windows

Fri Aug 9 05:32:13 PDT 2019

jranieri-grammatech marked an inline comment as done.
jranieri-grammatech added inline comments.

================
Comment at: clang/tools/scan-build/libexec/ccc-analyzer:121
 END {
-  if (defined $ResultFile && -z $ResultFile) {
     unlink($ResultFile);
----------------
NoQ wrote:
> Whoops. I suspect that we're now unconditionally deleting all plist output, which isn't exactly what we wanted. I think we actually wanted to delete //empty// plist files here.
Er, I think you're right. I was out of the office the last few days, but it looks like you've addressed this in rC368338. Thanks!

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65212/new/

https://reviews.llvm.org/D65212