[PATCH] D65994: Extended FPOptions with new attributes

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Aug 9 04:58:12 PDT 2019


aaron.ballman added a comment.

In general, this seems reasonable, but is missing test code.



================
Comment at: clang/include/clang/Basic/LangOptions.h:188
+    /// Rounding to nearest, corresponds to "round.tonearest".
+    ToNearest,
+    /// Rounding toward -Inf, corresponds to "round.downward".
----------------
Can you give these an `FPR` prefix?


================
Comment at: clang/include/clang/Basic/LangOptions.h:202
+    /// Assume that floating-point exceptions are masked.
+    Ignore,
+    /// Transformations do not cause new exceptions but may hide some.
----------------
And these an `FPE` prefix?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65994/new/

https://reviews.llvm.org/D65994





More information about the cfe-commits mailing list