[PATCH] D65988: [Clang Tablegen] Fix build when std::string::end() is not assignable

Orivej Desh via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Aug 8 17:51:08 PDT 2019


orivej created this revision.
orivej added a reviewer: clang.
orivej added a project: clang.
Herald added subscribers: cfe-commits, kadircet, arphaman.

This fixes Clang error: expression is not assignable:

  Result.erase(--Result.end());                                                        
               ^ ~~~~~~~~~~~~                                                          


Repository:
  rC Clang

https://reviews.llvm.org/D65988

Files:
  utils/TableGen/ClangDiagnosticsEmitter.cpp


Index: utils/TableGen/ClangDiagnosticsEmitter.cpp
===================================================================
--- utils/TableGen/ClangDiagnosticsEmitter.cpp
+++ utils/TableGen/ClangDiagnosticsEmitter.cpp
@@ -950,7 +950,7 @@
         Result += '|';
       }
       if (!P->Options.empty())
-        Result.erase(--Result.end());
+        Result.pop_back();
       Result += '}';
     }
     addInt(mapIndex(P->Index));
@@ -966,7 +966,7 @@
       Result += "|";
     }
     if (!P->Options.empty())
-      Result.erase(--Result.end());
+      Result.pop_back();
     Result += '}';
     addInt(mapIndex(P->Index));
   }


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D65988.214268.patch
Type: text/x-patch
Size: 626 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20190809/d7f1531b/attachment.bin>


More information about the cfe-commits mailing list