[PATCH] D65986: Allow setting the VFS to 'real' mode instead of default 'physical'

[Jonas Devlieghere via Phabricator via cfe-commits]

JDevlieghere added inline comments.


================
Comment at: clang/lib/Driver/Driver.cpp:172
+  case VFSMode::Unknown:
+    if (!this->VFS) {
+      LLVM_FALLTHROUGH;
----------------
Is this really necessary? 


================
Comment at: clang/lib/Driver/Driver.cpp:980
 
+  // We might try accessing the VFS fairly eatly, so make sure we have the
+  // right one.
----------------
`s/eatly/early/`


================
Comment at: clang/test/Driver/vfsmode.py:18
+current = os.path.realpath(os.curdir)
+name_max = int(subprocess.check_output("getconf NAME_MAX /", shell=True))
+path_max = int(subprocess.check_output("getconf PATH_MAX /", shell=True))
----------------
Can we pass `current` here?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65986/new/

https://reviews.llvm.org/D65986