[PATCH] D65835: [OpenMP] Fix map/is_device_ptr with DSA on combined directive
Joel E. Denny via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Aug 8 15:41:45 PDT 2019
jdenny added a comment.
In D65835#1621202 <https://reviews.llvm.org/D65835#1621202>, @ABataev wrote:
> >> See 2.19.7 Data-Mapping Attribute Rules, Clauses, and Directives
> >
> > I looked again. I'm still not finding any text in that section that implies is_device_ptr follows the same restrictions as map. Can you please cite specific lines of text instead of an entire section? Thanks for your help.
>
> Ah, it is only in OpenMP 5.0 anŠ² restrictions for the map clause are for map clause only. Then we should allow `is_device_ptr` with the private clauses for OpenMP 4.5.
I want to be sure we're on the same page: For OpenMP 5.0, should we allow `is_device_ptr` with the private clauses?
> Better to do this in a separate patch only for `is_device_ptr`.
I'll remove it from this one. Thanks.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D65835/new/
https://reviews.llvm.org/D65835
More information about the cfe-commits
mailing list