[PATCH] D65974: Driver: Don't warn about assembler flags being unused when not assembling AND not using the integrated assembler
Nico Weber via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Aug 8 15:02:39 PDT 2019
thakis added inline comments.
================
Comment at: clang/lib/Driver/ToolChains/Clang.cpp:3559
// CollectArgsForIntegratedAssembler().
- if (TC.useIntegratedAs()) {
+ if (TC.useIntegratedAs() || isa<PreprocessJobAction>(JA)) {
Args.ClaimAllArgs(options::OPT_mrelax_all);
----------------
We shouldn't claim the OPT_m flags if we don't use integrated-as. Claiming Wa_COMMA and Xassembler makes sense to me.
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D65974/new/
https://reviews.llvm.org/D65974
More information about the cfe-commits
mailing list