[PATCH] D65906: [clang-scan-deps] Fix edge cases in the minimizer

Duncan P. N. Exon Smith via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Aug 8 13:03:58 PDT 2019


dexonsmith added a comment.

In D65906#1621542 <https://reviews.llvm.org/D65906#1621542>, @aganea wrote:

> In D65906#1620034 <https://reviews.llvm.org/D65906#1620034>, @arphaman wrote:
>
> > Regarding the invisible characters before `#ifdef`, are you sure that's the right behavior?
>
>
> Should we then copy these invisible characters to the minimized output? Believe it or not, these characters are there in our codebase since 2013, and never clang has complained about it :)


Do you have an example command-line where clang doesn't error with your test file?  Alex gave you an example where it does error.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65906/new/

https://reviews.llvm.org/D65906





More information about the cfe-commits mailing list