[PATCH] D65943: [clangd] Added semantic highlighting support for primitives.

Haojian Wu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Aug 8 05:48:47 PDT 2019


hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.

nice, just a nit.



================
Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:138
+    // Builtins must be special cased as they do not have a TagDecl.
+    if (const auto *T = TL.getTypePtr())
+      if (T->isBuiltinType())
----------------
nit: we could merge this to the `if` below. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65943/new/

https://reviews.llvm.org/D65943





More information about the cfe-commits mailing list