[PATCH] D65906: [clang-scan-deps] Fix edge cases in the minimizer
Alex Lorenz via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Aug 7 15:52:16 PDT 2019
arphaman added a comment.
Thanks for figuring out these issues! It looks like you're fixing several edge cases, would you mind splitting the patch up for easier review?
Regarding the invisible characters before `#ifdef`, are you sure that's the right behavior? If you run the preprocessor over your test case, it doesn't accept it as a valid input, so why should the minimizer be different:
$ clang -cc1 -DTEST %t.c -Eonly -o -
%t.c:3:2: error: #endif without #if
#endif
^
1 error generated.
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D65906/new/
https://reviews.llvm.org/D65906
More information about the cfe-commits
mailing list