[PATCH] D65725: [analyzer] Mention whether an event is about a condition in a bug report part 2

[Artem Dergachev via Phabricator via cfe-commits]

NoQ accepted this revision.
NoQ added a comment.
This revision is now accepted and ready to land.

Accept as long as we agree on the wording as part of D65575 <https://reviews.llvm.org/D65575>.



================
Comment at: clang/test/Analysis/track-control-dependency-conditions.cpp:465
 void assert(int b) {
-  if (!b) // tracking-note{{Assuming 'b' is not equal to 0}}
+  if (!b) // tracking-note{{Assuming 'b' is not equal to 0, which will be (a part of a) condition}}
           // tracking-note at -1{{Taking false branch}}
----------------
Do i understand correctly that this test was passing previously, because `expected-note` matches substrings rather than the whole string? If we stick to the current wording, should we slowly switch to `expected-note-re{{{{^}}...{{$}}}}` in order to avoid such situations?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65725/new/

https://reviews.llvm.org/D65725