[PATCH] D65846: Improve error message from FrontendAction

[Argyrios Kyrtzidis via Phabricator via cfe-commits]

akyrtzi added a comment.

In D65846#1619752 <https://reviews.llvm.org/D65846#1619752>, @bruno wrote:

> > `clang -fmodules -fmodules-cache-path=...` is supposed to create the directory for the cache path, including the parent directories, AFAIK. If this doesn't happen it is a behavior change (and undesirable IMO).
>
> Is `c-index-test` invoking `clang` or do we just have a similar interface? Perhaps it's not doing it right (haven't seen this problem happening directly while invoking clang). Should `-fallow-pch-with-compiler-errors` be considered somehow here?


To clarify, `c-index-test` only uses the libclang APIs. JF said "The next line expects the directory to exist", which I assume refers to the `clang` invocation, which is why I mention that a clang invocation does not need to expect for the cache directory to exist.
Also `-fallow-pch-with-compiler-errors` is always enabled by the libclang API that is used to create a PCH.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65846/new/

https://reviews.llvm.org/D65846