[PATCH] D65846: Improve error message from FrontendAction

Argyrios Kyrtzidis via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Aug 7 13:13:55 PDT 2019


akyrtzi added a comment.

In D65846#1619645 <https://reviews.llvm.org/D65846#1619645>, @jfb wrote:

> My current guess is that this part of the test:
>
>   c-index-test -write-pch %t.h.pch %s -fmodules -fmodules-cache-path=%t.mcp -Xclang -triple -Xclang x86_64-apple-darwin
>
>
> Is expected to generate the `unknown type name` error, but when than happens it ignores `-fmodules-cache-path=%t.mcp` and doesn't create the directory. The next line expects the directory to exist, which is why it can't create the lock file (because the directory it's trying to create it in doesn't exist).


`clang -fmodules -fmodules-cache-path=...` is supposed to create the directory for the cache path, including the parent directories, AFAIK. If this doesn't happen it is a behavior change (and undesirable IMO).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65846/new/

https://reviews.llvm.org/D65846





More information about the cfe-commits mailing list