[PATCH] D65628: [clang-doc] Parallelize reducing phase

Diego Astiazarán via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Aug 7 12:38:20 PDT 2019


DiegoAstiazaran added inline comments.


================
Comment at: clang-tools-extra/clang-doc/tool/ClangDocMain.cpp:72
 
+static llvm::cl::opt<int> ThreadCount(
+    "thread-count",
----------------
juliehockett wrote:
> Can we use the pre-existing concurrency flag instead (https://github.com/llvm/llvm-project/blob/91e5cdfc93729c61c757db4efd4a82670ac7f929/clang/lib/Tooling/AllTUsExecution.cpp#L150)? It seems counterintuitive to have to set two different concurrency flags for one tool.
> 
> You'll have to put up a separate patch to expose that flag in the AllTUs header, so that you can access it (see rL344335, as an example). 
Done in D65833.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65628/new/

https://reviews.llvm.org/D65628





More information about the cfe-commits mailing list