[PATCH] D65510: [clangd] Fix implicit template instatiations appearing as topLevelDecls.
Johan Vikström via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Aug 7 07:59:44 PDT 2019
jvikstrom marked an inline comment as done.
jvikstrom added inline comments.
================
Comment at: clang-tools-extra/clangd/unittests/ClangdUnitTests.cpp:188
+ AllOf(DeclNamed("d"), WithTemplateArgs("")),
+ AllOf(DeclNamed("foo"), WithTemplateArgs("<>")),
+ AllOf(DeclNamed("foo"), WithTemplateArgs("<bool>"))}));
----------------
ilya-biryukov wrote:
> NIT: add `// FIXME: this should be '<T*>', not '<>'`
Already have a fix for it (it's a 2 line fix without the tests, should I just add do it in a separate CL or add it to this?)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D65510/new/
https://reviews.llvm.org/D65510
More information about the cfe-commits
mailing list