[PATCH] D65838: [Driver] Use enumeration for quoting mode. NFC
Shoaib Meenai via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Aug 6 17:45:59 PDT 2019
smeenai created this revision.
smeenai added reviewers: compnerd, phosek, rnk.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Boolean parameters are generally hard to understand, especially when we
don't consistently have a comment for them. Change to an enumeration.
While I believe this change is worthwhile by itself, its main purpose is
to serve as cleanup for a follow-up which will add a third mode to this
enumeration, to allow verbatim printing of arguments (without any
quoting or escaping).
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D65838
Files:
clang/include/clang/Driver/Job.h
clang/lib/Driver/Compilation.cpp
clang/lib/Driver/Driver.cpp
clang/lib/Driver/Job.cpp
clang/lib/Frontend/CreateInvocationFromCommandLine.cpp
clang/lib/Tooling/Tooling.cpp
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D65838.213765.patch
Type: text/x-patch
Size: 10217 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20190807/c9ca2b82/attachment-0001.bin>
More information about the cfe-commits
mailing list