[PATCH] D65019: [ARM] push LR before __gnu_mcount_nc on ARM
Jian Cai via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Aug 6 14:54:28 PDT 2019
jcai19 added a comment.
In D65019#1615898 <https://reviews.llvm.org/D65019#1615898>, @efriedma wrote:
> > introduce quite some code to the target-independent part of SelectionDAG, specifically SelectionDAGBuilder and SelectionDAG classes
>
> Not sure why you think this would be necessary. Every target has target-specific intrinsics, and we have infrastructure to ensure they don't require any changes to target-independent code.
I guess what I was trying to say was that I could not find a way to handle the new ARM intrinsic in SelectionDAGBuilder::visitTargetIntrinsic easily with the existing code so I had to introduce a case just for the ARM intrinsic in SelectionDAGBuilder::visitIntrinsic, and I am not sure if that is acceptable.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D65019/new/
https://reviews.llvm.org/D65019
More information about the cfe-commits
mailing list