[PATCH] D65065: [clang-tidy] Possibility of displaying duplicate warnings

Roman Lebedev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Aug 6 08:34:30 PDT 2019


lebedev.ri added a comment.

In D65065#1617031 <https://reviews.llvm.org/D65065#1617031>, @gribozavr wrote:

> > This suggestion would result another strange behavior: if the user disables cert-err09-cpp because he or she doesn't want to see its reports, the other one (cert-err61-cpp) will still report the issue. So he or she has to disable both (or as many aliases it has).
>
> That seems to be the case regardless of the implementation strategy in this patch.
>
> > This could be another advantage of this patch, since it would be annoying to see a message in which a GCC-style checker warns about an LLVM-style violation.
>
> I don't understand the scenario. I think people wouldn't enable both checkers in the first place.


They can silently get enabled if you follow the -Weverything approach - enable all checks, and selectively disable.
Current clang-tidy check aliasing really looks misdesigned..


Repository:
  rCTE Clang Tools Extra

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65065/new/

https://reviews.llvm.org/D65065





More information about the cfe-commits mailing list